[haiku-bugs] Re: [Haiku] #10880: haiku_loader can hang for minutes when one or more BIOS reported drives are unreadable
- From: "pdziepak" <trac@xxxxxxxxxxxx>
- Date: Wed, 28 May 2014 20:59:58 -0000
#10880: haiku_loader can hang for minutes when one or more BIOS reported drives
are
unreadable
----------------------------------+----------------------------
Reporter: MasterM | Owner: jessicah
Type: bug | Status: assigned
Priority: high | Milestone: R1/alpha5
Component: System/Boot Loader | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: x86
----------------------------------+----------------------------
Comment (by pdziepak):
1. Why try to read 512 bytes? Wouldn't 1 byte be enough?
2. Format string, `driveID` is `uint8` not `unsigned`.
3. That's probably out of scope of this patch but if I understand
correctly (basing on th description of this ticket) we should try some
perfect hashing here (without any bound on number of attempts) that
guarantees generation of collision-free hash table in O(n). I admit though
that I haven't fully read and understood the code in question yet, so this
suggestion may be wrong.
4. (that's to the "general audience", not only for you, MasterM) Why do we
expect people to send patches here? It is very inconvenient to review
anything if I cannot directly address the part of code I am unsure of. We
already have haiku-dev ML and git already has git send-email. Wouldn't it
be better to encourage people to use these?
--
Ticket URL: <https://dev.haiku-os.org/ticket/10880#comment:5>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
