[haiku-bugs] Re: [Haiku] #10510: Support Web Sockets (easy)
- From: "pulkomandy" <trac@xxxxxxxxxxxx>
- Date: Thu, 20 Mar 2014 15:07:55 -0000
#10510: Support Web Sockets (easy)
----------------------------------------+----------------------------
Reporter: pulkomandy | Owner: pulkomandy
Type: enhancement | Status: new
Priority: normal | Milestone: R1/beta1
Component: Applications/WebPositive | Version: R1/Development
Resolution: | Keywords: gsoc2014
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------------+----------------------------
Comment (by pulkomandy):
* Could you merge the two patches into one? (use git rebase -i)
* Please change the copyright in SocketStreamHandleHaiku. You rewrote all
of it, so assign copyright to yourself or to Haiku, Inc.
* You added a blank line after void receivedCancellation(const
AuthenticationChallenge&); , before the end of the class declaration.
This is not needed.
* #define READ_BUFFER_SIZE 1024 : a "static const int kReadBufferSize"
would be better. Maybe a BNetBuffer could be used instead (or a
BMallocIO), for dynamic sizing?
* The change to Source/JavaScriptCore/runtime/JSLock.cpp should not be in
the patch. Please remove it.
* Instead of using suspendThread, you should notify the thread using a
variable (used in the thread while loop, for example), to make the thread
exit the loop and properly terminate
* There are debug calls (to std::cout) left. Please remove those.
--
Ticket URL: <https://dev.haiku-os.org/ticket/10510#comment:9>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
