[haiku-bugs] Re: [Haiku] #10325: [PATCH] Make Haiku build on OS X Mavericks
- From: "pdziepak" <trac@xxxxxxxxxxxx>
- Date: Tue, 17 Dec 2013 19:45:37 -0000
#10325: [PATCH] Make Haiku build on OS X Mavericks
-------------------------+----------------------------
Reporter: js | Owner: nobody
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: - General | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
-------------------------+----------------------------
Comment (by pdziepak):
The sixth patch is definitely wrong. The new public symbol
`delete_driver_settings` was intentionally made weak so that it would not
causes any problems when a legacy binary also defines it.
I am also worried a bit about the first patch. We generally should be very
careful when using any compiler built-ins. Some of our functions differ
from what is defined by the standard (e.g. our `strdup()` accepts NULL
pointer). Using built-ins not only changes the behaviour of the function
but also may allow compiler to make some incorrect optimizations (we have
already had such problem during our unpleasant adventures with `-ftree-
vrp`).
Besides, AFAIK when cross compiling `-fno-builtin` is set, so the compiler
shouldn't use its own versions of `strl{cpy,cat}()` anyway.
--
Ticket URL: <http://dev.haiku-os.org/ticket/10325#comment:4>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
