[haiku-bugs] Re: [Haiku] #10231: Fixed uninitialized array in Terminal.

  • From: "pulkomandy" <trac@xxxxxxxxxxxx>
  • Date: Tue, 18 Nov 2014 15:00:43 -0000

#10231: Fixed uninitialized array in Terminal.
   Reporter:  Ezodev                 |      Owner:  siarzhuk
       Type:  bug                    |     Status:  closed
   Priority:  normal                 |  Milestone:  R1
  Component:  Applications/Terminal  |    Version:  R1/Development
 Resolution:  fixed                  |   Keywords:  gci2013
 Blocked By:                         |   Blocking:
Has a Patch:  1                      |   Platform:  All
Changes (by pulkomandy):

 * status:  assigned => closed
 * resolution:   => fixed


 Initialized the array in hrev48334.

 I followed the sequence used by Coverity and it is invalid, it jumps
 between states in way that the state tables in VPrsTbl.c would not allow
 (from CASE_ESC_IGNORE to CASE_ESC_DIGIT). The only way to enter ESC_DIGIT
 is from CASE_CSI_STATE, which sets the first element of the param array to
 DEFAULT. Then following elements of the array are initialized each time
 nparam is incremented.

 Just to be safe, the array is now cleared once when entering the function.

Ticket URL: <https://dev.haiku-os.org/ticket/10231#comment:6>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: