[haiku-bugs] Re: [Haiku] #10064: Unable to use Canna input method

  • From: "bonefish" <trac@xxxxxxxxxxxx>
  • Date: Thu, 21 Nov 2013 13:13:43 -0000

#10064: Unable to use Canna input method
------------------------------------+----------------------------
   Reporter:  X512                  |      Owner:  bonefish
       Type:  bug                   |     Status:  assigned
   Priority:  normal                |  Milestone:  R1
  Component:  Servers/input_server  |    Version:  R1/Development
 Resolution:                        |   Keywords:
 Blocked By:                        |   Blocking:
Has a Patch:  1                     |   Platform:  All
------------------------------------+----------------------------

Comment (by bonefish):

 Thanks for the patch!

 I still don't know what the data files are used for, so I can't really
 comment on whether copying them to the user's settings directory is a good
 solution. Disregarding that question, here are a few comments on your
 patch:
 * For finding the data directory, instead of using `find_directory()` to
 iterate through `B_USER_DATA_DIRECTORY` and `B_SYSTEM_DATA_DIRECTORY`, the
 new `BPathFinder` API should be used. That would look like:
 {{{
 status = BPathFinder(B_CURRENT_IMAGE_SYMBOL).FindPath(
   B_FIND_PATH_DATA_DIRECTORY, "Canna", B_FIND_PATH_EXISTING_ONLY, path);
 }}}
 * `copyData()` should rather be named `_CopyData()`.
 * The includes should be sorted alphabetically. "CopyEngine.h" being a
 private header should be in a separate block.

--
Ticket URL: <http://dev.haiku-os.org/ticket/10064#comment:9>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: