[haiku-bugs] Re: [Haiku] #10028: Make master build on Mac OS X again after PM-merge

  • From: "bonefish" <trac@xxxxxxxxxxxx>
  • Date: Sun, 29 Sep 2013 09:34:47 -0000

#10028: Make master build on Mac OS X again after PM-merge
   Reporter:  nielx         |      Owner:  bonefish
       Type:  bug           |     Status:  new
   Priority:  normal        |  Milestone:  R1
  Component:  Build System  |    Version:  R1/alpha4.1
 Resolution:                |   Keywords:
 Blocked By:                |   Blocking:
Has a Patch:  1             |   Platform:  All

Comment (by bonefish):

 0001, 0003, and 0005 look and can be applied.

 Regarding 0002:
  * typo: "HOST_PATFORM"
  * In the "if" the "![" and "]" need to be separated by whitespace from
 the enclosed condition.
  * I'd prefer a `HOST_EXTENDED_REGEX_SED` (= "sed -r" / "sed -E") build
 variable provided by "configure", so there that platform checks can be
 avoided in the actions.

 Regarding 0004:
  * A similar change is missing in [http://cgit.haiku-
  * Since half the build platforms don't support the "#else" implementation
 anyway and all support the "#if", I'd rather remove the "#else" altogether
 and make the "#if" unconditional.

Ticket URL: <http://dev.haiku-os.org/ticket/10028#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: