[haiku-appserver] Re: pageflipper OK but/ overlay CMAP8

  • From: Stefano Ceccherini <burton666@xxxxxxxxxxx>
  • To: haiku-appserver@xxxxxxxxxxxxx
  • Date: 9 May 2006 12:46:41 -0000

-----Messaggio Originale-----
Da: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
A: haiku-appserver@xxxxxxxxxxxxx
Data invio: Tue, 09 May 2006 14:34:20 +0200 CEST
Oggetto: Re: [haiku-appserver] Re: pageflipper OK but/ overlay CMAP8

>You misread me: the BWindowScreen already has the >kWindowScreenFeel 
>which makes it frontmost window (even menus open >behind it) - it just 
>doesn't span over the whole screen, as it doesn't >follow the resolution 
>changes. So there can be different windows on screen >at once, or at 
>least that's what the app_server sees.

Ah, ok now I understand. Looks like a bug then.
Speaking of bugs, I think I found one _I_ introduced.
In BWindowScreen::_SetupAccelerantHooks(),

if (fAddonImage < 0) {
    status = _InitClone();
    if (status == B_OK) {
I think that if (status == B_OK) should be moved out of the inner block, so 
that part is called even if fAddonImage is >= 0, like this:

if (fAddonImage < 0)
    status = _InitClone();
if (status == B_OK) {

At least, I was re-reading that part and I can't understand why I wrote it that 

Stefano Ceccherini aka Jack Burton
Mettiti al centro del mondo! Crea il tuo blog e condividi con
i tuoi amici idee, immagini e video, da web e da cellulare!

Other related posts: