[haiku-appserver] [Fwd: Re: [Haiku-commits] r12957 - in haiku/trunk: headers/private/app src/kits/app]

  • From: Adi Oanca <adioanca@xxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxx
  • Date: Mon, 06 Jun 2005 22:49:00 +0300

Sorry,
   dispatching this to app-server mailing list.


-------- Original Message --------
Subject: Re: [Haiku-commits] r12957 - in haiku/trunk: 
headers/private/app src/kits/app
Date: Mon, 06 Jun 2005 22:47:07 +0300
From: Adi Oanca <adioanca@xxxxxxxxxxxxx>
Reply-To: haiku-commits@xxxxxxxxxx
To: haiku-commits@xxxxxxxxxx
References: <200506041716.j54HGvYJ012901@xxxxxxxxxxxxxxxx>

Hi,

Axel 
Dïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïïï
 wrote:
> Author: axeld
> Date: 2005-06-04 19:16:49 +0200 (Sat, 04 Jun 2005)
> New Revision: 12957
> 
> Modified:
>    haiku/trunk/headers/private/app/AppServerLink.h
>    haiku/trunk/src/kits/app/AppServerLink.cpp
> Log:
> Private class BAppServerLink now has a global locker, instead of
> (ab)using the BApplication lock to synchronize messaging.

        Nice. Very nice.

> Also, it now has one global reply port, that is created on demand,
> but never freed - hope this doesn't cause any other trouble.

        Ufff... this stuff again.
        There is _no_ need for a second reply port. This behavior is a leftover
from the times of the first BPortLink implementation. All replies must
come through fServerTo BApplication's member. That's what it is for.
        Handlers for AS_SET_CURSOR_BCURSOR, AS_QUERY_CURSOR_HIDDEN, etc.,
methods from BApplication that set and get values were never ported to
the new communication API. At that time BPortLink was for sending
messages only, and every time a reply was needed it created a reply port
on the fly - costly.

        The fact is that we _do not_ need a global reply port, we merely need
to use BApplication::fServerTo.


thanks,
Adi.
_______________________________________________
Haiku-commits mailing list
Haiku-commits@xxxxxxxxxxxxxxxx
http://lists.berlios.de/mailman/listinfo/haiku-commits


Other related posts:

  • » [haiku-appserver] [Fwd: Re: [Haiku-commits] r12957 - in haiku/trunk: headers/private/app src/kits/app]