[haiku-3rdparty-dev] Re: [BeZillaBrowser] Coding guidelines
- From: Rahul Krishnan <pprahul@xxxxxxxxx>
- To: haiku-3rdparty-dev@xxxxxxxxxxxxx
- Date: Sun, 14 Feb 2010 10:24:40 +0530
Hi,
On Sat, Feb 13, 2010 at 11:52 PM, Matt Madia <mattmadia@xxxxxxxxx> wrote:
> On Sat, Feb 13, 2010 at 13:21, Rahul Krishnan <pprahul@xxxxxxxxx> wrote:
>
> > I would like to know if the code written as a generic one for all OS's
> could
> > be removed so that it is suited for Haiku.
> >
> > For e.g:
> > #ifdef USE_WIN_TITLE_STYLE
> > title="&prefWindow.titleWin;"
> > #else
> > title="&prefWindow.titleGNOME"
> > #endif
> >
> > Should these options be omitted and only the one with titleGNOME be put
> in
> > the code ?
> > I am not sure of the coding policies regarding BeZilla project integrated
> > into Haiku.
> >
>
> On one hand, it's good to leave the cross-platform code as-is. This
> way, merging these changes back to mozilla-central is slightly easier.
>
> Ya.. that's fine. I do agree with you.
> For #448, could you reattach a patch made with `hg diff
> mozilla/browser/base/content/browser-menubar.inc` ?
>
I've reattached the patches :
#448 : http://dev.osdrawer.net/attachments/236/448.diff
#427 : http://dev.osdrawer.net/attachments/237/427.diff
Do get back to me if any changes required.
>
> Thanks again for the patches and I'll apply them later in the week
>
> --mmadia
>
>
--
Rahul Krishnan
Amrita University '12
http://rahulkrishnanblogs.wordpress.com
Other related posts:
