[gpodder-devel] Incorrect extension detection

  • From: thp at perli.net (Thomas Perl)
  • Date: Sun, 11 Nov 2007 14:30:29 +0100

Hello, Nicolas!

On Fri, 2007-11-09 at 19:34 +0100, Nicolas Quienot wrote:
> I have noticed a problem with extension detection for the videos from
> this podcast :
> http://www.lemonde.fr/pod/sequence/0,2-811987,1-0,0.xml 
> 
> video files are stored with a ".xiti" extension, that's not a problem,
> my video player don't care about extension.
> 
> but this podcast is never synchronized to my ipod, because video
> podcast detection is based on extension. 
> 
> url of one episode :
> http://get.xiti.com/url.xiti?medias.lemonde.fr/mmpub/edt/vi/20071108/976236_tlzp_081107lg_prog.mp4?xts=43260&type=Podcast&flux=Le+Podcast+du+T%E9l%E9zapping&pod=le+podcast+du+t%E9l%E9zapping_07_11_2007
>  

I've updated the file_extension_from_url() function (that is responsible
for extracting the extension from a given URL) to check for known-good
extensions (video, audio, torrent) and if none is found, try to recurse
into the query string and find a known-good extension there.

This should provide a better extension detection algorithm. The code is
in gPodder's SVN trunk, if you are currently not working with the SVN
version, have a look at http://gpodder.berlios.de/running-from-svn.html
or wait for the next release.

I've also tested the new code with the feed you mentioned and the ".mp4"
extension is detected correctly now.

Thomas


Other related posts: