[gpodder] Re: Development news: "cuatro" branch and "master" branch
- From: Thomas Perl <th.perl@xxxxxxxxx>
- To: gpodder@xxxxxxxxxxxxx, Joseph Wickremasinghe <jnwickremasinghe@xxxxxxxxx>
- Date: Mon, 4 Nov 2013 20:09:01 +0100
Hey,
On 04 Nov 2013, at 08:37, Joseph Wickremasinghe <jnwickremasinghe@xxxxxxxxx>
wrote:
>> Sure - feel free to post in the blog. Have you had time to look into the
>> comments of the PR already? https://github.com/gpodder/gpodder/pull/104
>
> Thomas - I already addressed these issues and submitted a new pull request
> #108 which you already merged :)
>
> In future, when addressing comments in a pull request, should I add
> additional commits to that request (if such a thing is even possible), or
> close the PR and open a new one? (I've just closed PR #104, since we don't
> need it any more)
Yeah, that’s me not paying attention ;)
Either update the PR directly (e.g. by force-pushing the updated things to the
same branch, which should automatically update the PR) or close it / reference
it from the new PR, that’d be great :)
Thanks,
Thomas
Other related posts:
