On Mon, Mar 28, 2011 at 20:23, Thomas Perl <thp at gpodder.org> wrote: > Hello Dov, > > On Mon, Mar 28, 2011 at 12:22:14AM +0200, Dov Feldstern wrote: >> 1. I'm a little confused about the different branches --- as far as I >> can tell, there are two "stable" branches (excluding tres) currently >> being maintained: master and maemo-5 -- is that correct? What's the >> relation between them? The patch applies cleanly against both of them; >> but just so that I get a better understanding of the process: would it >> be applied separately to both, or applied to one and then merged into >> the other (and if so, in which direction)? > > The "master" branch is where the "stable" development happens. After > every release, the "master" branch is tagged and the tagged commit is > then merged into the "maemo-5" branch. Then, the Debian packaging is > updated in the "maemo-5" branch, and a release is made (and it's also > tagged with "fremantle/..."). So basically, "maemo-5" tracks "master" > and just includes some Maemo-specific changes and the packaging info. > Thanks for the clarifications! I've added this information to the gPodder wiki (http://wiki.gpodder.org/wiki/Running_gPodder_from_Git#A_note_about_the_branches). >> 2. Should I open a bug report / feature request for this, or is that >> not necessary? > > Yes, please. This helps me queue up tasks and quickly merge/process > bugs, features and patches without having to wade through e-mails :) > >> 3. While working on this, I also noticed that the "visit website" >> option seems to have been disabled at some point, attached is another >> patch which re-enables it. > > Please also open a bug report for that and attach the patch. > >> This is my first foray into gpodder code, so any comments will be >> greatly appreciated...! > > I'll give some feedback when you've created the bugs and added the > patches - this way, the patch discussion is attached to the patch. > > I hope that's not too much red tape for you :) > Sure, no problem! Opened two requests at bugs.maemo.org: https://bugs.maemo.org/show_bug.cgi?id=12100 https://bugs.maemo.org/show_bug.cgi?id=12101 Thanks! (And thanks a lot for gPodder! ;) ) Dov