Sorry for the late reply. Not that much time the last weeks.
On 2018-04-03 11:27, Sebastian Humenda wrote:
Hi all
A few of the things below discuss points of our infrastructure and especially
on
the `make install` rule, I would like to hear your comments: have you ever
used
it, what are your feelings about it?
Einhard Leichtfuß wrote:
A note on the Makefile (tools/mk/dicts.mk)What makes you beleive that only the dict server is restarted? `dictdconfig`
- As noted above, the install target attempts to restart dictd. I do not
consider that a good idea. Particularly, it won't have the desired
effect (on Arch at least), as restarting dictd does not add the
dictionary files to dictd.conf.
is
run as well, required for dictd to learn about new databases.
Also, there may be reasons not to restart dictd, e.g. when installingI'm not a big fan of this script anyway. Debian simply doesn't use it and it
many dictionaries at a time, since restarting dictd (at least using
systemd) several times in a row may make it fail.
was
only kept because Michael deemed it useful for development. Is it a problem to
not use `make install` on Arch? I'm also open for removing the make install
rule
all together, but it's nice to have it, as I said, for ddevelopment purposes.
If we should keep it, could you provide a patch to make it work on Arch as
well?
I've tried to make it work on multiple distributions, without actual knowledge
of the other environments.
- Also, I'd like documentation files being copied by `make install'. IIMHO that is the task of a package maintainer :), but maybe you have a
currently do not use `make install' in my packages, but instead
manually copy the files, including any of AUTHORS, README, NEWS,
ChangeLog, if existing.
different
opinion on that. Where would you install these files to? Dictd usually wants
it
dictionaries under /usr/share/dictd on Debian, a place where the doc files
shouldn't go to, they go under /usr/share/doc/<PKGNAME>/doc. But I reckon this
is Debian-specific.
- Checksums are great. Maybe you could provide such in the API?Brilliant, what do you want, MD5?
Currently, my script fetches the sources / binaries on every update,
just to calculate the checksum.
- In the "list of clients" on GitHub, I miss the mention of `dict',Fixed.
being part of dictd itself, as far as I know. In my eyes, the most
Also, the XFCE4 dictionary [0] may be considered worth including.Could you please add this? If you give me your user name (PM is fine), I'll
add
you as a collaborator.
Attachment:
signature.asc
Description: OpenPGP digital signature