[dokuwiki] Re: [patch] small install.php improvements

  • From: Andreas Haerter <dokuwiki@xxxxxxxxxxxxxxxxxx>
  • To: dokuwiki@xxxxxxxxxxxxx
  • Date: Mon, 25 Oct 2010 11:11:19 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 24.10.2010 09:53, schrieb Andreas Gohr:
>> 1) the "@" before date() does not change install.php's behavior, it
>> simply suppresses an uncritical PHP warning, triggered on *many* systems
>> during the installation (poor first impression for new users!).
> 
> I talked with Adrian about it and assumed he had fixed that already.
> Seems I was wrong. I changed it to gmdate.

Cool, thank you! :-)


>> 2) Allowing the "." in superusernames is changing install.php's behavior
>> in a way to act more like DokuWiki's cleanID() without leading to any
>> dependencies.
> 
> We'd need to make sure that people don't use a dot at the start or end
> or multiple dots... basically we'd need to to reimplement parts of
> what cleanID does.

Oooops... you're right *shame on me*


> Since we have feature freeze and this has always
> been as it is now, I say let's have a look at this after the release.

OK. :-)

- -- 
Andreas <http://blog.andreas-haerter.com>

()  ascii ribbon campaign - against html e-mail
/\  www.asciiribbon.org   - against proprietary attachments

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkzFSbcACgkQkQNYqObGxVBHEwCfeAS5r1Wivulo35ft0OKMeiP5
5FsAn2jDkv4ZRclSh8K70WBUAV+p3k6F
=msX7
-----END PGP SIGNATURE-----
-- 
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist

Other related posts: