[dokuwiki] Re: [patch] small install.php improvements
- From: Andreas Haerter <dokuwiki@xxxxxxxxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Sat, 23 Oct 2010 16:14:16 +0200
Hi Adrian,
Hi Andi,
Last try before the release of Lazy Sunday... *hope someone will apply
the patch*
Am 17.10.2010 14:46, schrieb Adrian Lang:
> Andreas Gohr <andi@xxxxxxxxxxxxxx> wrote:
>
>> We wanted the installer to have no dependencies into the dokuwiki
>> core. That means there is no cleanID() available which is used to
>> clean usernames in the plain auth backend. That is why we restricted
>> the installer option for usernames to somewhat very basic.
>
> I would think a file called 'common.php' (not our commons.php, though)
> would be appropriate for inclusion by an 'install.php'. Just a handful
> of very basic helper functions.
I did not do anything like that cause Andi Gohr told me month ago, the
install.php should not have any dependencies:
<//www.freelists.org/post/dokuwiki/installerphp-reason-for-very-strict-usernamefiltering-for-the-superuseraccount,1>
However: is there any problem with my patch? If not: please apply it
before Lazy Sunday release ;-)
1) the "@" before date() does not change install.php's behavior, it
simply suppresses an uncritical PHP warning, triggered on *many* systems
during the installation (poor first impression for new users!).
2) Allowing the "." in superusernames is changing install.php's behavior
in a way to act more like DokuWiki's cleanID() without leading to any
dependencies.
--
Andreas <http://blog.andreas-haerter.com>
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
