[dokuwiki] Re: jQuery rewrite
- From: Michael Hamann <michael@xxxxxxxxxxxxxxxx>
- To: rezlemic <rezlemic@xxxxxxxxxxx>
- Date: Tue, 29 Mar 2011 21:58:21 +0200
Hi Michal,
Excerpts from rezlemic's message of 2011-03-29 01:32:11 +0200:
> Excerpts from Michael Hamann's message of 2011-03-28 01:15
> > some additional thoughts about the jQuery rewrite:
> > We really need to keep the current JavaScript API for some releases so
> > plugins authors have enough time to upgrade their JavaScript code.
> > Michal, could you take care of this and not remove the old code that
> > exposes functionality to plugins and add the parts again that have
> > already been removed? There should be a plan which files should be
> > removed but they should not be removed yet.
>
> OK, I'm sorry, I have not realized the dependency of plugin authors on
> API :-(. I corrected it today to the original form. API is the same as
> it was now and in the implementation of files I have already rewritten
> is used jQuery.
No problem, I hadn't thought about that problem/requirement in the first
place, too. I'm also not sure if Pierre Spring has already removed
things that might be required by plugins.
> > [...]
> > Michal, for the case you shouldn't be able to finish the complete jQuery
> > rewrite till the deadline could you please create a list of open tasks
> > so we can see what's left to do? It would be good if you could get so
> > far that we'll be able to merge the changes and the open tasks don't
> > affect the usage.
>
> OK, I hope I will rewrite all files in /lib/scripts/ directory. If the
> rewrite is not complete to my deadline of school project, I can
> continue in my work then longer (independently on my school project),
> if you want. I just need to show my work at school to pass a subject
> now, but I am not going to left you then :-).
Okay, that's even better, you should however make sure that the code we
should merge works and doesn't break too many plugins (or even doesn't
break any plugins if possible, but see below).
> I just have a question about my rewrite. As you have written, the
> current JS API should not be changed. But for example the original
> media.js was written so that it was possible to call functions i.e.:
> "media_manager.togglekeepopen()" external. After rewrite of this file
> (I haven't rewritten this file, I have only solved conflicts by
> merging) it is not possible to do that. The functions (like
> togglekeepopen(),...) are "private" in anonymous function now. Should
> I correct it too?
Hm, that's a good question. I would say it's unlikely there are plugins
that use that functionality, but perhaps Hakan (who has a copy of all
plugins) could tell us more about that? Apart from that it's nice to
have ways for plugins to interact with the JavaScript code, but on the
other hand I'm not sure we really need that many possibilities in the
plugin manager. What do you (Michal and also all the other people on the
list) think?
Or in other words: Not everything that is possible in the current
version needs to be possible in the jQuery version. It's just really
important that the helper functions that are used by many plugins still
work.
Michael
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
