[dokuwiki] Re: inc/DifferenceEngine.php
- From: Robin Getz <robin.getz@xxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Thu, 27 Jan 2011 16:31:43 -0500
ping.
Anyone comment on the GUI questions?
and the css still seems to be missing.
On Mon 29 Nov 2010 11:25, Robin Getz pondered:
> On Mon 29 Nov 2010 10:24, Andreas Gohr pondered:
> > On Mon, Nov 29, 2010 at 4:12 PM, Robin Getz <rgetz@xxxxxxxxxxxxxxxxxxxx>
> wrote:
> > > On Sat 20 Nov 2010 06:00, Andreas Gohr pondered:
> > >> Hi Robin,
> > >
> > > Sorry for the delay - I was out of the office for awhile.
> > >
> > >> >> > Due to a request from our technical writers, I'm in process
> > >> >> > of adding a in-line diff to inc/DifferenceEngine.php which
> > >> >> > generates something like:
> > >> >> > http://software.zuavra.net/inline-diff/diff_example_0.2.html
> > >> >> > (using the existing infrastructure)...
> > >>
> > >> I just applied your changes to inc/DifferenceEngine.php but not the
> > >> interface changes. I'm not too keen to add this via JavaScript...
>
> OK - the DifferenceEngine will now generate a <span class="diff-addedline"> &
> <span class="diff-deletedline"> - so that needs to be added to the default
> design.css as well (it was in the patch I sent to the mailing list).
>
> > > Just to understand better - why not Javascript for this?
> >
> > I like to have core functionality work without JavaScript.
>
> When Javascript was disabled, you would see the existing behaviour.
> (side by side, no radio buttons), so it depends on if you say that
> "core" was the ability to switch views, or "core" is just a side by
> side diff... ?
>
> > > But it doesn't really matter - that was just one solution...
> > >
> > >> I think we should rather add a drop down to the difference view where
> > >> people can easily switch the wanted type of output (we could even add
> > >> unified diff to the options).
> > >
> > > Sure - I was just going from what someone had shown me a in different
> > > CMS...
> > >
> > > Plus I wasn't sure how to code the drop down to toggle the view without
> > > a little javascript...
> >
> > Have a submit button and use JavaScript to remove it and make the form
> > autosubmit...
>
> Which is OK with me, as long as the proposed submit button doesn't preclude
> the use of html_diff() in plugins. For example:
> http://www.dokuwiki.org/plugin:diffpreview
>
> > >> Maybe we should also store their last
> > >> choice in the session or a cookie?
> > >
> > > That is what the Javascript did, so yeah, I think it needs to be there.
> >
> > Ah. didn't notice.
> >
> > >> What do others think?
> > >
> > > Did you mean for this to go to the list?
> >
> > Yes, it was. Again, this is why mailinglist replies should always be
> > sent to the list only and not CCed to the original sender.
>
> Yeah, someone poked me about this - It appears to be an anomaly in freelists
> (at least to me) - as most other mailing list managers don't require this.
> Will do in the future.
>
> -Robin
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
