[dokuwiki] Re: git changes 2010-12-09
- From: Robin Getz <robin.getz@xxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Mon, 13 Dec 2010 15:28:34 -0500
On Mon 13 Dec 2010 13:09, Andreas Gohr pondered:
> > Isn't this the a more general fix?
> >
> > + $addr = explode(':',$_SERVER['SERVER_NAME']);
>
> No this doesn't change anything.
Sure it does - it has the same:
+ if(!$host) $host = 'example.com';
in it that yours did.
> The problem occurs when running a
> command line script - in that case neither SERVER_NAME nor HTTP_HOST
> are set because there is no HTTP environment, in that case the
> DOKU_URL is set to ./ which isn't parsable with parse_url().
Right - so are we better off fixing the DOKU_URL so that it is parsable?
Does the fix belong in inc/mail.php:mail_setup() which fixes the mail problem,
but maybe not everything - or in inc/init.php:getBaseURL() which should make
sure that DOKU_URL is OK?
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
