[dokuwiki] Re: diffpreview plugin, and the ability to select diff views...

  • From: "Getz, Robin" <robin.getz@xxxxxxxxxx>
  • To: <dokuwiki@xxxxxxxxxxxxx>
  • Date: Mon, 7 Nov 2011 17:10:21 -0400

On Mon 7 Nov 2011 05:57, Andreas Gohr pondered:
> >> We use the diffpreview plugin,
> >> It looks as if the "sidebyside" or "inline" options which show up on the
> >> revisions page, does not work with this plugin - and you are stuck with
> >> sidebyside.
> >
> > I can imagine this plugin was written before the inline diff view was
> > introduced (so, since Rincewind).
> Correct. The plugin doesn't pass any third type parameter to the
> html_diff function:

I guess I was a little surprised to see this, since it actually worked with 
the javascript patch I sent originally (which you didn't like, nor commit).

> Adding a choice what format to use for preview diffs could possibly
> clutter the interface quite a bit. 

I didn't get any negative feedback about the original js implementation with 

> Maybe a way to set the type as a config for the diffpreview plugin 
> would be a good idea? 

What I have found is there are some which are much easier to view side by 
side, and others which are much easier to read in-line. Having the option 
makes things much easier to deal with...

DokuWiki mailing list - more info at

Other related posts: