[dokuwiki] Re: Tweaking authentication
- From: Chris Smith <chris@xxxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Tue, 24 Jan 2006 07:42:44 +0000
Quick question.
Currently the parts of dokuwiki that use ACL test for it by checking
$conf['useacl']. Under the OO system its now possible for
$conf['useacl'] to be set and for the initialisation of the auth object
to fail. If that ever were to happen, php would hit fatal errors -
method called on non-object. That is obviously undesirable.
If auth initialisation fails should:
- dokuwiki die immediately with some suitable error message
- carry on without auth, the user would be treated as not logged in,
parts of dokuwiki which require auth would not be available[1]
- allow config to specify one or other of the above.
[1] which would require adding (or replacing) $conf['useacl'] checks
with isset($auth) , or having auth.php set $conf['useacl'] to 0.
Generally, I'd be against modifying a $conf value during operation. In
this case it may be suitable.
Comments?
Apart from this the two auth mods (remove legacy auth support & add
canDo() method) are ready to be recorded and sent.
Cheers,
Chris
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist
Other related posts: