[dokuwiki] Plugin plugin and TarLib.class

  • From: Håkan Sandell <hakan.sandell@xxxxxxx>
  • To: <dokuwiki@xxxxxxxxxxxxx>
  • Date: Mon, 27 Apr 2009 10:19:28 -0700

Hi all,
 
I had some problems with the plugin plugin on my "Dokuwiki on a Stick"
running on Vista, download of zipped files worked but not tgz.  
Before submitting a patch and answering the forum
http://forum.dokuwiki.org/thread/2681 I want a second opinion so I don't
mess things up.
 
The temporary directory created with io_mktmpdir() by the plugin plugin
looks like
 
C:\DokuWikiStick5\dokuwiki\data\tmp985d8141502b0a947c95df8889c43ead
 
the problem is that somewhere around row 825 in TarLib.class.php
(function _extractList) the path is adjusted
 
    if (!$p_to ||
($p_to[0]!="/"&&substr($p_to,0,3)!="../"&&substr($p_to,1,3)!=":\\")) /*"
// <- PHP Coder bug */
      $p_to = "./$p_to";
 
now we get
./C:\DokuWikiStick5\dokuwiki\data\tmp985d8141502b0a947c95df8889c43ead
and function fails. If it wasn't for the cryptic comment I probably just
had submitted
 
    if (!$p_to ||
($p_to[0]!="/"&&substr($p_to,0,3)!="../"&&substr($p_to,1,3)!=":\\"&&subs
tr($p_to,1,2)!=":/")) /*" // <- PHP Coder bug */

Any comments? Please enlighten me...
 
/Håkan


<P><p><font face="Arial, Helvetica, sans-serif" size="2" 
style="font-size:13.5px">_______________________________________________________________<BR><a
 style="font-family: Tahoma, sans-serif; font-size: 10px; color: #00f" 
href="http://www.eniro.se/?partnerid=spray_mail"; target="_blank">Eniro Supersök 
- är vad det heter</a></font>

Other related posts: