[dokuwiki] Re: [PATCH] search problems and solutions

  • From: Andreas Gohr <andi@xxxxxxxxxxxxxx>
  • To: dokuwiki@xxxxxxxxxxxxx
  • Date: Wed, 1 Jun 2005 20:22:56 +0200

Matthias Grimm <matthiasgrimm@xxxxxxxxxxxxxxxxxxxxx> wrote:

> 1. The search input accepts more than one word but more words result
> in more results. I would expect that I narrow the search with more
> words to find. I analyzed the code and found that DokuWiki combined
> the query words with 'OR' instead of 'AND' as I expected and as most
> search engines(for eg. google) work.
> 
> The patch 'search_combination_and.patch solved the problem and closes
> FS#158, I think, as additonal benefit.

Hmm I like it and will probably add it, but let's think about it first ;-) The 
former method combined all word into a single regular expression. Your code 
uses a regexp for each word. So if I use three words I roughly triple the time 
used on matching. Does anyone know a way on combining the search words into one 
regexp? Maybe using assertions?

 
> The patch 'keep_search_input.patch' maked me happy ;-)

Accepted.

BTW: I added an intermediate develsnap tag which solved the problem of the ever 
growing context in the darcs patches. In the future I only plan to tag 
releases...

Andi

Other related posts: