[dokuwiki] Re: Maintainability of underscored CSS files
- From: Anika Henke <anika@xxxxxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Wed, 10 Oct 2012 11:40:17 +0100
I have pushed this now, with the following changes.
1. Don't add any font declarations.
The bad guy here is *_diff.css*, because "table.diff td" has the
*monospace
font* stack.
Options:
a. Leave as it is.
b. Just add the generic "monospace" and move the specific font
declaration
to content.css
c. Remove the font declaration completely and move it to
content.css.
d. Add new __font_monospace__ (and then also __font_body__ and
__font_headings__) to style.ini. But that would break the next rule.
Andi: I'd say a)
Anika: b)
"Done": a)
2. Don't use any not guarenteed placeholders.
There are two different issues:
i. *_links.css* contains *__existing__ and __missing__*.
Options:
a. Leave as it is.
b. Add __existing__ and __missing__ to the list of guarenteed
placeholders.
c. Move the offending lines to content.css.
d. Remove _links.css and move its content to content.css. This
would
also help the next rule.
Andi: I like b)
Anika: c) or d)
Done: c) as discussed in our last IRC meeting on Sunday
ii. *_media_fullscreen.css and _search.css* contain *__highlight__*.
Options:
a. Leave as it is.
b. Add __highlight__ to the list of guarenteed placeholders.
c. Move the offending lines to content.css.
Andi: I like b)
Anika: b)
Done: b)
Template authors, this means you need to make sure to always include
__highlight__ in your style.ini.
3. Don't add non-core images.
This is probably the least problematic, as those images only need to be
copied over. There are two different issues:
i. *_links.css* needs the three icons *external-link|unc|email.png*.
Options:
a. Leave as it is.
b. Move the images to the core images folder. (Their colour is a
generic
grey.)
c. Move the offending lines to content.css.
d. Remove _links.css and move its content to content.css.
Andi: Here I slightly tend to c) but would be fine with b)
Anika: not sure -- Now I think b), c) or d) (so, anything but a) ).
Done: b)
My reasoning was that the vast majority of template authors never change
them.
ii. *_toc.css* needs the four icons
*bullet|open|closed|closed-rtl.png*.
Options:
a. Leave as it is.
b. Move the images to the core images folder. (Their colour is a
generic
grey.)
c. Move the offending lines to content.css.
Andi: Here I lean more to b)
Anika: not sure -- Now I think b) might be good, because it's more a
core than a template thing and templates very rarely change them.
Done: b)
Cheers,
Anika
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
