[dokuwiki] FW: Re: bug squashing
- From: "Chris Smith" <chris@xxxxxxxxxxxxxxxxx>
- To: <dokuwiki@xxxxxxxxxxxxx>
- Date: Fri, 17 Jun 2005 20:37:42 +0100
apologies if you recieve this twice, but again my first send seems to have
disappeared into the ether.
-----Original Message-----
From: Chris Smith [mailto:chris@xxxxxxxxxxxxxxxxx]
Sent: 17 June 2005 15:54
To: 'dokuwiki@xxxxxxxxxxxxx'
Subject: RE: [dokuwiki] Re: bug squashing
On Fri, 17 Jun 2005 12:48:35 +0200
Andreas Gohr <andi@xxxxxxxxxxxxxx> wrote:
> Hi all!
>
> I'd like to prepare a new release and want to remove as much bugs as
possible before. Any help would be greatly appreciated.
I took a look at #287. It seems pretty straight forward to fix. <html>
should not be generating block close and block open. Removing 'html' from
the arrays of tokens that do that seems to correct the problem. My simple
testing hasn't shown any problems.
If someone with a greater knowledge of the parser would care to cast an eye
over the fix - its detailed in my comment on that bug report
http://bugs.splitbrain.org/?do=details&id=287
There seems to be a larger problem with block markup being used in list
items. List text is surrounded by a span and in valid xhtml a span
shouldn't include a block element. I am pretty sure the span can be
replaced by a div with no ill effects. Certainly none in my basic testing.
The necessary changes are then:
inc/parser/xhtml.php ~ #277 - 282, replace the <span> and </span> with <div>
and </div>
lib/tpl/default/design.css #365, change span.li to .li (can add a div, but I
don't think its necessary)
If someone with a greater understanding of the parser doesn't forsee any
problems with this fix I can parcel it up and send the fix through to Andi.
Cheers,
Chris
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist
Other related posts:
- » [dokuwiki] FW: Re: bug squashing
