[dokuwiki] Re: Bureaucracy plugin
- From: Damien Regad <dregad@xxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Sat, 5 May 2018 17:14:31 +0200
Somehow I sent the message before was finished writing it... sorry !
Here's the complete version
Hello Michael,
Thanks for the feedback.
On 2018-05-04 18:53, Michael Große wrote:
I working on improving this in
https://github.com/splitbrain/dokuwiki-plugin-bureaucracy/pull/247. ;
I had a quick look at that PR, and made some comments because the yesno
test case is failing.
It would be great if you could ensure that all code that your pull
requests are touching is sufficiently covered by tests.
However, please note that in my opinion, the following 3 PR's are
simple, housekeeping fixes that should be mergeable without additional
unit tests, so I hope that you can process them.
https://github.com/splitbrain/dokuwiki-plugin-bureaucracy/pull/220
https://github.com/splitbrain/dokuwiki-plugin-bureaucracy/pull/221
https://github.com/splitbrain/dokuwiki-plugin-bureaucracy/pull/242
I will see if I can improve the tests for the "chained actions" feature
and related functionality.
But it would be nice if adding tests could be treated as a separate,
independent work item, and not as a condition for merging a new
functionality that should not affect existing plugin behavior.
Other related posts:
