[dokuwiki] Re: Autosubmit popularity data (FS2025)
- From: Michael Hamann <michael@xxxxxxxxxxxxxxxx>
- To: dokuwiki <dokuwiki@xxxxxxxxxxxxx>
- Date: Sat, 27 Nov 2010 12:40:08 +0100
Hi,
Excerpts from Guillaume Turri's message of 2010-11-27 09:03:40 +0100:
[...]
> Here is an other patch for FS2025, which follows this advice
Great, that one looks much better than the previous one!
> I think some things may still be improved (in particular, regarding the UI),
> but I first would like to know what you think of it.
I think you are doing the things now in the way they should be done,
there are just some minor things you could improve and some ideas on how
the user interface could be improved:
- use Doku_Form instead of manually generating the HTML for the form
- getInfo() should already be implemented in the parent class of the
plugin so with plugin.info.txt you don't need to implement getInfo().
- for the code in the admin part that is used in the action part a
helper part or just another php file would imho be good/better style.
- Probably loading the admin/helper part only in the handler would make
sense as that handler won't be called every time the plugin is loaded
- I think when the submission of the data fails a message file should be
written that then triggers the display of an error message on the
admin page of the popularity plugin. So you can see something like
"Data was last submitted successfully on ..." or "There was a failure
submitting the data on ...: $error_message" and also the date of the
next time the data will be submitted could be displayed.
- When the manual submission fails (e.g. because it isn't possible to
use outgoing http connections on the server) a possibility could be
offered to submit the data directly from the browser like it is done
now.
Regards,
Michael
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
