Created #415 to capture this change.
On Fri, Jul 17, 2020 at 7:45 AM bareheiny <dmarc-noreply@xxxxxxxxxxxxx>
wrote:
Works for me - generic enough to describe what’s happening, without
treating the user as an idiot and spelling everything out.
On 17/07/2020, at 23:35, Darryl L. Pierce <mcpierce@xxxxxxxxx> wrote:
I agree on removing the CV mention. With issue #301 I'm moving the backend
towards being able to use multiple scraping sources. Once it's merged,
it'll soon be as simple as writing a replacing ScrapingAdaptor class, add
the underlying actions to fetch data, and everything else will be handled
by the framework.
Let me stew on the verbage. Maybe we should just remove references to
metadata and scraping altogether and have the title be "Update Comic
Details" and the message be "Are you sure you want to retrieving the
comic's details using this source?" Since the user will have to know what
scraping is and have done some work to get the needed pieces, such as an
API key, we don't need to dumb it down a lot. But keeping it focused on the
process updating the details of the issue might keep the point clear.
Thoughts?
On Thu, Jul 16, 2020 at 10:39 PM Guy Incognito <
dmarc-noreply@xxxxxxxxxxxxx> wrote:
To be sure, this is all about semantics and pedanticism 😉
I think something along the lines of “Save metadata for this issue?” for
the title, and maybe “Are you sure you want to save the scraped metadata
for this issue?“
I’m thinking it may be best not to mention ComicVine...unless there are
no plans to include other scrapers...
*From: *Darryl L. Pierce <mcpierce@xxxxxxxxx>
*Sent: *Friday, 17 July 2020 1:22 PM
*To: *comixed-dev@xxxxxxxxxxxxx
*Subject: *[comixed-dev] Re: Scrape This Issue? confirmation box.
Not to be pedantic, but it's not rescraping: until you click Submit the
meta-data for the comic hasn't been retrieved: only the volume name, the
number of issues in that volume and the URL for the comic's cover have been
retrieved. Nothing's really be scraped at that point.
But, that all said, what would are some alternative text options for the
heading and message in that dialog?
On Thu, Jul 16, 2020 at 7:47 PM bareheiny <dmarc-noreply@xxxxxxxxxxxxx>
wrote:
The “extra information” step is what I meant by “re-scraping”.
In that sense, you are scraping the comic...but also saving the
metadata. I think the confirmation should reflect the saving aspect over
the scraping more details.
On 17/07/2020, at 10:35, Darryl L. Pierce <mcpierce@xxxxxxxxx> wrote:
No, there's no rescraping (unless you tell it to skip the cache). But
when you press the "Select" button the data hasn't been loaded yet for the
comic.
The flow is this:
1. When you click the "Fetch" button, the backend goes to CV to find
possible volumes that match the series name in the input field.
* It only retrieves a minimal amount of data for the volume.
2. When the data's received, it preselects the volume that has the same
start year as what's entered in the input field and whose name exactly
matches.
3. When you click on a volume, the backend goes to CV and tries to get
the minimum amount of data (the issue # and the cover URL) for any issue in
the volume that matches the issue number in the input field.
* If no such issue exists then you won't see a cover
4. When you click the Select button, the backend then goes to CV to get
the *MORE* set of information for:
* the volume,
* the issue, and
* the publisher.
NOTE: At each step, data is cached in the database so that the backend
doesn't always have to go back to CV to get information. The data is held
for up to 7 days before being considered expired and cleared out.
On Thu, Jul 16, 2020 at 4:14 PM Guy Incognito <
dmarc-noreply@xxxxxxxxxxxxx> wrote:
I just had to google “what is scraping”, because I wasn’t actually sure
of the definition!
So with that in mind, I think the first step in scraping is actually the
scraping – metadata is being scrapped from ComicVine. I see this as the
fetch function. But fetch also applies, as we’re fetching metadata.
In my view, when we press the “select” button, we’re saving the scrapped
/ fetched metadata...rather than re-scraping ComicVine. Unless that’s
what’s actually happening? Is CX actually re-scraping for additional
information?
*From: *Darryl L. Pierce <mcpierce@xxxxxxxxx>
*Sent: *Friday, 17 July 2020 2:32 AM
*To: *comixed-dev@xxxxxxxxxxxxx
*Subject: *[comixed-dev] Re: Scrape This Issue? confirmation box.
I believe that diskette icon is the FontAwesome "save" icon, though I'm
not seeing where we're putting that into the dialog. It looks like
PrimeNG's ConfirmationService is doing that.
I thought scraping was generally understood here: you've just clicked a
volume and then the "Select" button, so the backend is scraping the data
from ComicVine and applying it to the current comic.
I'm open to changing text, definitely, if it helps make things clearer to
the user. What would be a suggestion for that?
On Thu, Jul 16, 2020 at 4:01 AM Guy Incognito <
dmarc-noreply@xxxxxxxxxxxxx> wrote:
This may apply in 0.6, I haven’t confirmed – so raising it in the dev
mailing list.
I find the diskette icon off-putting here, as it doesn’t seem to belong.
I’m also not sure about the title – what is “scraping”? I feel like I’ve
done that part, and am not saving metadata. That may be a matter of
semantics, but it could be worth discussing.
<3AD8A52FF114414083E99D0BBCC8C841.png>
Also not keen on the capitalisation, but I’ve raised that in GitHub.
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." - Gord
Downie
