Thanks, that will make it easier!
On Sat, Jun 27, 2020 at 9:25 PM Darryl L. Pierce <mcpierce@xxxxxxxxx> wrote:
Joao, I've pushed a PR for initial Portuguese support. After it's merged,
we'll just need you to translate the entries in the assets/i18n/pt
directory before we push 0.8 in September.
On Sat, Jun 27, 2020 at 9:43 AM Darryl L. Pierce <mcpierce@xxxxxxxxx>
wrote:
Another translation would be awesome!
I've created the ticket (#371) and assigned it to both you and me. I'll
do the change to add the base files for Portuguese and the entry in the
dropdown list and push up a PR. Then you can take the issue over to do the
translations.
And thank you! :D
On Sat, Jun 27, 2020 at 5:57 AM João Miguel Côrte-Real França Pereira <
jmcrfp@xxxxxxxxx> wrote:
Sorry about that, I was doing the smart lists feature but I got stuck
with the frontend part and then I got distracted with other things. (Maybe
you could give me some pointer to the frontend)
I will try to at least review some PRs.
Maybe I could also do the translation to Portuguese.
On Thu, Jun 25, 2020 at 9:01 PM Darryl L. Pierce <mcpierce@xxxxxxxxx>
wrote:
That's okay, this will give you the practice. :D
On Thu, Jun 25, 2020 at 3:58 PM Frédéric Fouret <
fouretfrederic@xxxxxxxxx> wrote:
Why not, I could make some code reviews. Just be aware that I don't
have much practice ;)
Le jeu. 25 juin 2020 à 16:06, Darryl L. Pierce <mcpierce@xxxxxxxxx> a
écrit :
I've been taking it on myself to merge PRs that I've put up so long
as they pass SonarCloud's tests. But I'd like to get into the habit of
having at least one other pair of eyes review them before merging. Joao
used to do some but I've not seen him active here lately, and he didn't
review the last few that I had sent to him as reviewer.
I understand if any of you can't do them consistently or if it would
take you a few days to get to a review. And I'm not asking anybody to
commit to doing all of them. But I would like to get us at least a pool
of
people who can at least grab a PR when it's pushed and agree to review it
within, say, 3-5 days? Then I can push the PR and you can grab them and
then do your review within a few days.
Thanks.
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." - Gord
Downie
