Quick comment: when commit changes, please use square brackets [] rather
than parentheses () on the first line to enclose the ticket number. Just to
keep all commit messages consistent.
On Wed, Jul 1, 2020 at 2:01 PM Darryl L. Pierce <mcpierce@xxxxxxxxx> wrote:
Just replied on the PR, but will post here as well for others. This link
takes you through the PR review process:
https://docs.github.com/en/enterprise/2.13/user/articles/reviewing-proposed-changes-in-a-pull-request
Basically, the steps are:
1. Start the review while adding a comment to one of the diffs.
2. If there are no changes needed, you can select "Approve" and then go on
to merge the PR.
3. If there are changes needed, you can select "Request Changes" and
submit the review.
4. If you just want to provide feedback but not a final decision, you can
just select "Comment" there.
On Wed, Jul 1, 2020 at 12:10 PM Frédéric Fouret <fouretfrederic@xxxxxxxxx>
wrote:
I have a question. After doing a review, I can't rebase merge (or merge)
in github. How to do rebase merge ?
Le mer. 1 juil. 2020 à 17:26, Darryl L. Pierce <mcpierce@xxxxxxxxx> a
écrit :
I've created a few PRs and have added multiple people as requested
reviewers. But, to be fair, I don't think we need to have all reviewers
approve the PR to merge it. If any one reviewer finds the PR meets
standards then they can go ahead and do a rebase merge (I'd like to avoid
squash merges unless a PR is a LOT of individual commits) and close the PR.
On Thu, Jun 25, 2020 at 10:05 AM Darryl L. Pierce <mcpierce@xxxxxxxxx>
wrote:
I've been taking it on myself to merge PRs that I've put up so long as
they pass SonarCloud's tests. But I'd like to get into the habit of having
at least one other pair of eyes review them before merging. Joao used to do
some but I've not seen him active here lately, and he didn't review the
last few that I had sent to him as reviewer.
I understand if any of you can't do them consistently or if it would
take you a few days to get to a review. And I'm not asking anybody to
commit to doing all of them. But I would like to get us at least a pool of
people who can at least grab a PR when it's pushed and agree to review it
within, say, 3-5 days? Then I can push the PR and you can grab them and
then do your review within a few days.
Thanks.
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." - Gord
Downie
