Excellent. :D
I'm doing some additional changes to it. Mainly removing one
dependency (@stomp/stompjs) with a better library (webstomp-client).
The code's a lot cleaner and simpler to maintain. I'm mainly now
trying to bring the unit test coverage up on it and will push it
before tomorrow.
On Wed, Mar 10, 2021 at 1:04 PM Frédéric Fouret
<fouretfrederic@xxxxxxxxx> wrote:
I couldn't review the pull request today (due to an internet failure). I will
do it tomorrow.
From what I've seen, it looks good, simple to implement and effective for
updating the frontend.
Le mar. 9 mars 2021 à 15:56, Darryl L. Pierce <mcpierce@xxxxxxxxx> a écrit :
I've added a new PR for putting STOMP messaging into the system:
https://github.com/comixed/comixed/pull/641
This is a BIG game changer, as I mentioned in my other email. This
code, once incorporated, will make updating the frontend WAY easier
than how it's done now. Changes the comics, reading lists, etc. can
all be published asynchronously to all connected browsers.
Since this is a big change, I'd appreciate some eyes on it. It won't
be included until the next release, but I've got plans that require
getting this core piece merged once it's been reviewed.
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
