Hey, Darryl...
I saw your comments for the PR. Sorry, I am not that familiar with github,
I've basically used it for personal projects... Learning as I go.
I solved almost all issues you mentioned, but wanted to discuss about a
couple of them:
.
- You requested me to cite [#348], which is the PR, but looking at other
PRs, I saw they were citing the issue that gave reason for them, so I cited
[#332] instead... Is this ok? Otherwise I will ammend those
- You requested to remove the single quotes in 'bloqueado' /
'desbloqueado'. Before doing so, let me explain why I put those there, and
let me know what you think:
In English, you are using sentences like, "Mark pages Blocked"... the
capital B somehow singles "Blocked" as an special status.
In Spanish, it is incorrect using capitals in the sentences like that,
and "bloquear"/"bloqueado" is a rather generic word, which in this context
takes a special meaning, so I thought showing them between single quotes
would make more sense for the Spanish user. I know it is not standard in
comixed, so, if you think that will not work, I'll go ahead and remove those
On Sat, Jun 13, 2020 at 2:01 PM Darryl L. Pierce <mcpierce@xxxxxxxxx> wrote:
The best way is to create a fork and submit PRs as you mention. The
central repo doesn't allow commits directly to any branches.
On Sat, Jun 13, 2020 at 7:48 AM Arturo Pérez Mulas <
theotocopulitos@xxxxxxxxx> wrote:
Hey, Darryl,
How do I go about adding my translations... should I fork and make a PR,
or just commit directly to the develop branch in the main repository?
On Wed, Jun 10, 2020 at 8:59 PM Arturo Pérez Mulas <
theotocopulitos@xxxxxxxxx> wrote:
Thanks!
On Wed, Jun 10, 2020 at 8:36 PM Darryl L. Pierce <mcpierce@xxxxxxxxx>
wrote:
I've started on the first 0.7 feature by checking in today the
different sets of files to support other languages. There are now
directories containing the files to be translated into French and Spanish.
For doing the translations, the project uses a tool named
ngx-translate-messageformat-compiler [1] that supports having plurals and
other things in the translations. They're not difficult to use, and the
English translation takes advantage of them. But I can help if there are
any questions.
[1] https://github.com/lephyrus/ngx-translate-messageformat-compiler
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." - Gord
Downie
