It looks like the importer code didn't get formatted since that submodule's
currently commented out in the main pom.xml file. So, yeah, please
uncomment that and push up a PR for that and the code reformatting when you
can and we'll get that merged.
Can you also copy into that submodule the new logback-test.xml file I've
added to other submodules? This is to throttle the logging output on Travis
since our new project's builds are failing there due to excessive output
(which is weird because the same code doesn't fail on my personal Travis
builds on the same site).
On Thu, Nov 21, 2019 at 7:29 PM João Miguel Côrte-Real França Pereira <
jmcrfp@xxxxxxxxx> wrote:
The comixed-importer didn't get to be formated. Do you want me to do it
and push it?
Btw what are your thoughts on put it on sonarcloud also?
A quarta, 20/11/2019, 14:06, João Miguel Côrte-Real França Pereira <
jmcrfp@xxxxxxxxx> escreveu:
Nice!
On Wed, Nov 20, 2019 at 11:35 AM Darryl L. Pierce <mcpierce@xxxxxxxxx>
wrote:
Done and done. I've reformatted all of the Java code to create a
baseline for us to use.
On Wed, Nov 20, 2019 at 4:34 AM João Miguel Côrte-Real França Pereira <
jmcrfp@xxxxxxxxx> wrote:
It's ok by me.
Maybe you could do a full code reformatting now, so that we don't get
reformatting withing normal commits, that really makes it hard to review.
On Wed, Nov 20, 2019 at 3:02 AM Darryl L. Pierce <mcpierce@xxxxxxxxx>
wrote:
To make things easier, I'd like to introduce some form of automated
code formatting for Java.
We already a configuration in the comixed-frontend submodule for use
by Prettier on Typescript code.
I'm looking currently at maven-git-code-format for use on the Java
side of the project. WIth it we can enforce the Google Java formatting
standard on the code. To format code we only need to do:
$ mvn git-code-format:format-code
from the root and it formats the entire project. So that way we can
all work locally with whatever code convention we prefer. But when
checking
in the code, we can run this plugin from the command line (or if you use
IntelliJ like I do you can just enable the google-java-format plugin) and
the code will be purely changes and not contain any reformatting-only
lines.
What are everybody's thoughts on this?
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
--
Darryl L. Pierce <mcpierce@xxxxxxxxx>
"Le centre du monde est partout." - Blaise Pascal
"Let's try and find some point of transcendence and leap together." -
Gord Downie
