On Thu, Oct 8, 2015 at 7:22 PM, Wolfgang Mauerer
<wolfgang.mauerer@xxxxxxxxxxxxxxxxx> wrote:
Hi Mitchell,
Am 08/10/2015 um 17:57 schrieb Mitchell Joblin:
Signed-off-by: Mitchell Joblin <mitchell.joblin.ext@xxxxxxxxxxx>
that's fairly uncontroversial, obviously. However, can you please
document (in the commit description) why we need the package?
We had to remove installed packages in the past, and it took
a while to ascertain whether they are needed or not. If it's documented
why a new package was needed in the first place, it's easier to
find out later if it can be removed.
Acked-by: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxxxxxxxx>
Thanks, Wolfgang
---
README.md | 2 +-
integration-scripts/install_codeface_R.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/README.md b/README.md
index a7d72a6..e11c727 100644
--- a/README.md
+++ b/README.md
@@ -102,7 +102,7 @@ in the step "Database Setup", and modify codeface.conf
accordingly.
"scales", "gridExtra", "scales", "RMySQL",
"RCurl", "mgcv", "shiny", "dtw", "httpuv",
"devtools",
"corrgram", "logging", "png", "rjson", "lsa",
"ineq",
- "arules", "data.table", "RJSONIO"),
dependencies=T)
+ "arules", "data.table", "RJSONIO",
"markovchain"), dependencies=T)
If necessary, make sure _before_ the installation that
`/usr/local/lib/R/site-library/` is writeable by the current user
diff --git a/integration-scripts/install_codeface_R.sh
b/integration-scripts/install_codeface_R.sh
index 58ebf04..08ae796 100755
--- a/integration-scripts/install_codeface_R.sh
+++ b/integration-scripts/install_codeface_R.sh
@@ -9,7 +9,7 @@ sudo DEBIAN_FRONTEND=noninteractive apt-get -qqy install
r-base r-base-dev r-cra
r-cran-scales r-cran-RMySQL r-cran-RJSONIO r-cran-RCurl r-cran-mgcv \
r-cran-shiny r-cran-dtw r-cran-httpuv r-cran-png \
r-cran-rjson r-cran-lsa r-cran-testthat r-cran-arules
r-cran-data.table \
- r-cran-ineq libx11-dev libssh2-1-dev r-bioc-biocinstaller
+ r-cran-ineq libx11-dev libssh2-1-dev r-bioc-biocinstaller
r-cran-markovchain
sudo Rscript packages.R
