[codeface] Re: [PATCH 12/19] Format to PEP8 in codeface/ts.py

  • From: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxxxxxxxx>
  • To: <codeface@xxxxxxxxxxxxx>
  • Date: Tue, 16 Feb 2016 16:52:21 +0100



Am 16/02/2016 um 13:40 schrieb Andreas Ringlstetter:

From: Benjamin Hiefner <benjamin.hiefner@xxxxxxxxxxxxxxxxxxxx>

Signed-off-by: Benjamin Hiefner <benjamin.hiefner@xxxxxxxxxxxxxxxxxxxx>
---
 codeface/ts.py | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/codeface/ts.py b/codeface/ts.py
index 0b400b6..ed0e9ad 100644
--- a/codeface/ts.py
+++ b/codeface/ts.py
@@ -18,18 +18,14 @@
 
 # Create time series from a sequence of VCS objects
 
-import yaml
+import argparse
 import os.path
-import kerninfo
 import pickle
-import argparse
-from datetime import datetime
 
-from .VCS import gitVCS
-from .commit_analysis import createCumulativeSeries, createSeries, \
-    writeToFile, getSeriesDuration
+from .commit_analysis import createSeries
 from .dbmanager import DBManager, tstamp_to_sql
 
+# TODO remove sfx ?

no TODOs in cleanup series
 def doAnalysis(dbfilename, destdir, revrange=None, rc_start=None):
     pkl_file = open(dbfilename, 'rb')
     vcs = pickle.load(pkl_file)
@@ -43,6 +39,7 @@ def doAnalysis(dbfilename, destdir, revrange=None, 
rc_start=None):
     res = createSeries(vcs, "__main__", revrange, rc_start)
     return res
 
+
 def writeReleases(dbm, tstamps, conf):
     pid = dbm.getProjectID(conf["project"], conf["tagging"])
 
@@ -52,12 +49,13 @@ def writeReleases(dbm, tstamps, conf):
                    (tstamp_to_sql(int(tstamp[2])), pid, tstamp[0], 
tstamp[1]))
     dbm.doCommit()
 
+
 def dispatch_ts_analysis(resdir, conf):
     dbpath = resdir
     destdir = os.path.join(dbpath, "ts")
     dbm = DBManager(conf)
 
-    if not(os.path.exists(destdir)):
+    if not os.path.exists(destdir):
         os.mkdir(destdir)
 
     # Stage 1: Create the individual time series (and record all time
@@ -67,23 +65,26 @@ def dispatch_ts_analysis(resdir, conf):
     # not rely on the content of tstamps before that is done.
     tstamps = []
     for i in range(1, len(conf["revisions"])):
-        dbfilename = os.path.join(dbpath, 
"{0}-{1}".format(conf["revisions"][i-1],
-                                                           
conf["revisions"][i]),
+        dbfilename = os.path.join(dbpath,
+                                  "{0}-{1}".format(conf["revisions"][i - 1],
+                                                   conf["revisions"][i]),
                                   "vcs_analysis.db")
 
         ts = doAnalysis(dbfilename, destdir,
-                        revrange=[conf["revisions"][i-1], 
conf["revisions"][i]],
+                        revrange=[conf["revisions"][i - 1],
+                                  conf["revisions"][i]],
                         rc_start=conf["rcs"][i])
 
-        if (i==1):
-            tstamps.append(("release", conf["revisions"][i-1], 
ts.get_start()))
+        if i == 1:
+            tstamps.append(
+                ("release", conf["revisions"][i - 1], ts.get_start()))
 
-        if (ts.get_rc_start()):
+        if ts.get_rc_start():
             tstamps.append(("rc", conf["rcs"][i], ts.get_rc_start()))
 
         tstamps.append(("release", conf["revisions"][i], ts.get_end()))
 
-    ## Stage 2: Insert time stamps for all releases considered into the 
database
+    # Stage 2: Insert time stamps for all releases considered into the 
database
     writeReleases(dbm, tstamps, conf)
 
 if __name__ == "__main__":


Acked-by: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxx>

Other related posts: