[codeface] Re: [PATCH 0/9] Feature-aware Collaboration Analysis

  • From: Matthias Dittrich <matthi.d@xxxxxxxxxxxxxx>
  • To: codeface@xxxxxxxxxxxxx
  • Date: Tue, 18 Nov 2014 14:48:27 +0100

Hi Wolfgang,

On 17.11.2014 16:05, Wolfgang Mauerer wrote:
Am 17/10/2014 15:14, schrieb Matthias Dittrich:
Pull request athttps://github.com/siemens/codeface/pull/8.
These are the same changes but sent to the mailing list.
See the commit messages for a detailed description.

I hope this is the format you expected.
the format is perfect, thank you very much for the effort
to re-structure your patch stack! Sorry for the long delay
in reviewing the changes.
Thanks for the review!
So the next steps are reworking the commits (after some discussion). Then adding your signed-off tag? And finally resubmitting the modified patches to the mailing list, right? Or should I now directly connect to Mitchell to get the changes into his branch?
Or both?
Sorry I'm a bit confused at this point. I will now just start working on the commits and fix what you have mentioned. What if I have some more changes now which could be squashed, is it better to integrate them on the next round or leave them separate (to move forward) and just fix what has been mentioned?

Best regards, Matthias
Best regards, Wolfgang
Matthias Dittrich (9):
   upgrade to latest nodejs changes.
   Change imports to make the files better standalone executable within
     pydev IDE (especially unit tests).
   Fix of some typos in code comments.
   Fixed typo bugs in code (noticed by pycharm).
   Add a _getFeatureLines function which calculates feature sets for all
     source code lines.
   Extract parsing functionality of _getFeatureLines in separate
     functions to make them unit-testable.
   Add unit tests for the getFeatureLines functions.
   Added clustering functions for feature analysis.
   Integrate feature analysis by providing a CLI parameter.

  README.md                                         |   2 +-
  codeface/VCS.py                                   | 221 ++++++++++++++-
  codeface/cli.py                                   |  15 +-
  codeface/cluster/cluster.py                       | 312 +++++++++++++++++++++-
  codeface/fileCommit.py                            |  64 +++++
  codeface/project.py                               |   4 +-
  codeface/test/integration/test_exampleprojects.py |   6 +-
  codeface/test/unit/test_getFeatureLines.py        | 169 ++++++++++++
  id_service/id_service.js                          |   9 +-
  9 files changed, 767 insertions(+), 35 deletions(-)
  create mode 100644 codeface/test/unit/test_getFeatureLines.py



Other related posts: