[codeface] Re: [PATCH 0/9] Codebase cleanup part 1

  • From: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxxxxxxxx>
  • To: <codeface@xxxxxxxxxxxxx>, Andreas Ringlstetter <andreas.ringlstetter@xxxxxxxxxxxxxxxxxxxx>
  • Date: Wed, 16 Sep 2015 15:07:33 +0200



Am 15/09/2015 um 03:43 schrieb Andreas Ringlstetter:

From: Andreas Ringlstetter <andreas.ringlstetter@xxxxxxxxx>

First set of patches in a series to clean up the codebase. This set provides
no functional changes yet and should be safe to apply.

After applying this set, all legacy python scripts in experiments/ are no
longer
supported by the provision process in Vagrant or Travis. rpy2 and matplotlib
Python modules are no longer installed by default.

thanks, the series contains valuable changes. I'll merge after my
comments have been addressed (no need to route via the mailing list,
just send a pull request). For the series,

Reviewed-by: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxxxxxxxx>

Best regards, Wolfgang Mauerer


Travis CI and vagrant provision both passed after applying all patches onto
current master.

The next set in this series will contain patches which update the formating
of various Python files around the codebase to conform with PEP8. This may
cause conflicts with unmerged changes in any local codebase. Functional
changes will only be introduced once the formating has been fixed.



Andreas Ringlstetter (9):
Remove dead tests from cluster/cluster.py
Fix unresolvable variable in cluster.py computeProximityLinks
Remove deprecated tests from cluster/idManager.py
Fix unresolvable variable in dbmanager.py get_release_range()
Move interactive.py to experiments
Move cdist.py to experiments
Fix imports in adist.py
Update setuptools prior to using pip again
Exclude experiments folder from provision

codeface/cdist.py | 56 ----------------------
codeface/cluster/cluster.py | 66
+-------------------------
codeface/cluster/idManager.py | 11 -----
codeface/dbmanager.py | 2 +-
codeface/interactive.py | 29 -----------
experiments/adist.py | 6 +--
experiments/cdist.py | 56 ++++++++++++++++++++++
experiments/interactive.py | 29 +++++++++++
integration-scripts/install_codeface_python.sh | 3 +-
integration-scripts/install_common.sh | 2 +-
setup.py | 6 +--
11 files changed, 97 insertions(+), 169 deletions(-)
delete mode 100755 codeface/cdist.py
delete mode 100644 codeface/interactive.py
create mode 100755 experiments/cdist.py
create mode 100644 experiments/interactive.py


Other related posts: