On Wed, Oct 21, 2015 at 2:46 PM, Wolfgang Mauerer
<wolfgang.mauerer@xxxxxxxxxxxxxxxxx> wrote:
Dear all,
Am 21/10/2015 um 13:34 schrieb Mitchell Joblin:
Hi all,
I seem to have never ending misery with the file line endings. There
are odd consequences the end up causing Codeface to fail because
trying to execute the file results in "file not found" even though its
in the directory (e.g. this occurred for the persons.r file). Also git
add has weird behavior, it simply will not allow some files to be
staged. What is the strategy to handle this issue once and for all? I
can look more deeply into this issue myself but whoever made the
change may wish to voice their more informed opinion regarding the
appropriate solution.
the ones who proposed the patch should take care of handling the issue.
Patches should lead to good things :) But we keep having more and more
problems, so this needs to be fixed properly.
Mitchell, could you please provide a reproducible example? I do not
have the issue, so there seems to be a dependency on something.
Thanks, Wolfgang
Thanks,
Mitchell
On Tue, Oct 13, 2015 at 2:37 PM, Wolfgang Mauerer
<wolfgang.mauerer@xxxxxxxxxxxxxxxxx> wrote:
Am 13/10/2015 um 14:29 schrieb Mitchell Joblin:
On Tue, Oct 13, 2015 at 2:21 PM, Wolfgang Mauerer
<wolfgang.mauerer@xxxxxxxxxxxxxxxxx> wrote:
Hi Mitchell,
Am 13/10/2015 um 14:16 schrieb Mitchell Joblin:
Hi all,
I am not really sure what is going on with the edits to this patch but
maybe its related to the line endings issues. Git basically does allow
you to do anything until these changes are commited.
Has anyone else had this happen?
does the Java patch still apply properly after you have modified
it with this patch? (I.e., does the patched patch still work)?
I didn't try. I have never applied that patches before. It looks like
I need to install some more packages before I can apply them. At least
that path doesn't exist on my installation yet. I can try to test that
later.
to clarify: I was not asking if the b4j library still works after
applying the patch, only if the patch applies correctly with the
sanitised line endings. IIRC, the b4j sources use a mix of different
line endings, or at least this patch introduces a mix.
Since the bug tracking analysis is not actively being used right
now and is anyway being rewritten ATM, the question is if we should
a) get rid of the patches completely (in this case, we can also get
rid of the current version of the bug tracking analysis, because
it won't then anyway anymore)
b) turn of the CRLF conversion for these files, and keep them around
until a better bug tracker parser is merged.
c) fix the patch files so that they apply cleanly, but do not cause
crlf conversion issues.
Any opinions?
Thanks, Wolfgang
--Mitchell
Thanks, Wolfgang
Kind regards,
Mitchell
