[ciphershed] Re: #if 0
- From: "Jason Pyeron" <jpyeron@xxxxxxxx>
- To: <ciphershed@xxxxxxxxxxxxx>
- Date: Tue, 1 Jul 2014 10:46:31 -0400
> -----Original Message-----
> From: ciphershed-bounce@xxxxxxxxxxxxx
> [mailto:ciphershed-bounce@xxxxxxxxxxxxx] On Behalf Of Jason Pyeron
> Sent: Tuesday, July 01, 2014 10:34
> To: ciphershed@xxxxxxxxxxxxx
> Subject: [ciphershed] Re: #if 0
>
> > -----Original Message-----
> > From: Bill Cox
> > Sent: Tuesday, July 01, 2014 9:58
> >
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On 7/1/2014 12:26 AM, Jason Pyeron wrote:
> > >> -----Original Message----- From: Bill Cox Sent: Tuesday, July 01,
> > >> 2014 0:07
> > >>
> > >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
> > >>
> > >> On 6/30/2014 8:14 PM, Jason Pyeron wrote:
> > >>> Should we fix code in these blocks or strip them form the code
> > >>> base?
> > >>
> > >> I find them informative. We could rip them at the first major
> > >> rewrite, where I hope we can replace the E4M code.
>
> 100% (unless licensed in a permissive way) of the code has to
> be replaced, but I
> am curious do we "know" which parts are from E4M?
>
> > >
> > > Then I will fix the sprintf calls inside the if 0 blocks too.
> >
> > Seriously, I would not bother fixing the sprintf calls in code we're
> > going to replace anyway. Instead of putting time into
> fixing it, I'd
>
> I become more familiar with the code this way. A complete
> re-write will take
> some time, and minor edits like this help bridge the gap.
I have found locations where the code shoves wide characters into byte wide char
arrays, assumption of the char width at 1 or 2 bytes, etc...
If I am an engineer surveying a dam for replacement, and I see springing leaks,
do I not plug them?
>
> Sprintf is used in a few files (greped):
>
> src/Common/Cmdline.c
> src/Common/Dlgcode.c
> src/Common/Language.c
> src/Common/Random.c
> src/Common/Registry.c
> src/Common/SecurityToken.cpp
> src/Common/Tcdefs.h
> src/Common/Volumes.c
> src/Core/Unix/Linux/CoreLinux.cpp
> src/Format/InPlace.c
> src/Format/Tcformat.c
> src/Main/Forms/EncryptionTestDialog.cpp
> src/Mount/Hotkeys.c
> src/Mount/Mount.c
> src/Setup/ComSetup.cpp
> src/Setup/SelfExtract.c
> src/Setup/Setup.c
> src/Setup/Wizard.c
>
> > rather work on replacing it. The rebranding patch looks good to me
> > as-is. I'd prefer to move on to build automation and testing.
>
> I am also working on tests as I go.
>
> >
> > I think we should talk about a set of release tasks.
>
> I have windows command line building working here already
> (1st step since I ssh
> to my windows box), I am trying to get a mechanism to
> build/test from git
> branches on windows(32/64) and linux(32/64).
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
- -
- Jason Pyeron PD Inc. http://www.pdinc.us -
- Principal Consultant 10 West 24th Street #100 -
- +1 (443) 269-1555 x333 Baltimore, Maryland 21218 -
- -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.
Other related posts:
