[cats-devel] Re: Spawner PR

  • From: Denis Rotanov <denis@xxxxxxxxxxx>
  • To: cats-devel@xxxxxxxxxxxxx
  • Date: Sun, 07 Jun 2015 15:36:25 +1000



On 07.06.2015 15:13, Alexander Klenin wrote:

Still no cake:
sp.exe "zzz"
old version:
CreateProcess failed with error code 2: The system cannot find the
file specified.
new version:
E:\Work\Spawner\libspawner\src\win32\runner.cpp:162:CreateProcess:
"zzz", error code: 87: The parameter is incorrect.
you have probably corrupted GetLastError somehow.

Also, you have broken cats-judge:
old version:
SpawnerError: <none>
new version:
SpawnerError: no error

Please test your changes carefully.

Artem, do you see this conversation? Can you rebuild Spawner and
re-run your tests?

I fixed `no error` -> `<none>`. However error code 87 instead of 2 is cause `of restore_original_environment(original); ` now overwriting GetLastError(). It did not before, I don't know if it's me or Artem, but I doubt this has something to do with error handling. I'll fix it by moving PANIC above, just after failed CreateProcess. There's no point in cleaning up stuff if we're in panic. PR's coming in five minutes.

Other related posts: