Am 24.05.2008 um 09:22 schrieb Grzegorz Dąbrowski:
On Fri, 23 May 2008 15:41:21 -0700 "scott mc" <scottmc2@xxxxxxxxx> wrote:Andreas, On the Curl.diff you have, #ifdef __BEOS__ #ifdef __HAIKU__ /* Haiku has FD_SET defined in sys/socket.h and no socket.h */ #include <sys/socket.h> #else /* BeOS has FD_SET defined in socket.h */ #include <socket.h> #endif #endif Shouldn't this be rewritten like this, for the day when __BEOS__ is removed from Haiku? Also what should happen for Bone/Zeta on this?In my opinion the patch should be dropped because <sys/socket.h> is included in curl already for Haiku.
This is not the whole patch[1], it can't just be dropped. This section thereof cannot be dropped completely either because it wouldn't build then as long as we still define __BEOS__. I don't make changes just for fun! It can be prettified though, in the way Scott suggested.
Andreas [1] http://tools.assembla.com/BePorts/browser/BePorts/trunk/net-misc/curl/curl-CVS.diff?rev=68 -- BePorts homepage - http://tools.assembla.com/BePorts List archives: //www.freelists.org/archives/beports Administrative contact: brecht@xxxxxxxxxxx
