[argyllcms] Typos and freeing bad food

  • From: "kevin smiley" <kevin.m.smiley@xxxxxxxxx>
  • To: argyllcms@xxxxxxxxxxxxx
  • Date: Fri, 24 Oct 2008 14:20:18 -0400

I've noticed some things while looking through the Argyll 1.0.3 source
directory.
./makefile line 9: "install:;". Make wouldn't run until I replaced
that semicolon with a colon.
./XICC/xmatrix.c line 1027: "printf("Done gama[...]". that gamma
appears to be missing an "M".
.scanin/scanrd.c line 2101: "em = "More BOXes that declared";" What
does this mean?


Scanin is consistently crashing when I execute it with a particular
tiff. Debugging shows that it is trying to free the char pointer
sr->out, which is pointing to apparently empty memory at 0xbaadf00d.
An ad-hoc stack trace:

scanin.c, line 1282:
        sr->free(sr);
scanrd.c, line 514:
        if (s->out != NULL)
                free(s->out);

Is there any harm in changing line 514 to "if (s->out != NULL &&
s->out != 0xbaadf00d)"?
I am also curious as to why sr->out is pointing to 0xbaadf00d to begin with.

Kevin Smiley

Other related posts: