Hi Lotte,
Comments in line (sorry for the format, I'm using my phone):
On 3 Apr 2016 09:31, "Lotte Steenbrink" <lotte.steenbrink@xxxxxxxxxxxx>
wrote:
make it clear that both those conditions should be satisfied, ie matching
Hi vicky,
Am 03.04.2016 um 02:01 schrieb Victoria Mercieca <vmercieca0@xxxxxxxxx>:
Hey Lotte,
This looks great...one miniscule nitpick - in your new text for 6.2 I'd
the route gets copied to RIB and used in FIB...does AODVv2 need to use it
Good catch! Done. :)
Is LocalRoute.NextHopInterface used mainly for forwarding...? i.e. when
triggered it was received.
Oh, I think that’s a good point. I’ve added
The RREP MUST be sent over the same interface on which the REEQ that
to the end of the RREP Generation section,
was received.
The RREP MUST be sent over the same interface on which the previous RREP
to RREP regeneration,
It MUST be sent over the same interface on which the RREP that triggeredit was received.
follows:
to RREP_Ack Generation, changed RERR generation and RERR regeneration as
message, i.e., if PktSource is included, the RERR SHOULD be
If the RERR is sent in response to an undeliverable IP packet or RREP
sent unicast to the next hop on the route to PktSource. It MUST be sentover the same interface on which the undeliverable IP packet was received.
multicast to LL-MANET-Routers. If the RERR is sent in response to abroken link, i.e., PktSource is not included, the RERR is,
by default, multicast to LL-MANET-Routers.the behaviour of different interfaces may vary?
… But shouldn’t the same apply to RREQs as well? Even if it is multicast,
Monitoring influences the validity of routes, shouldn’t
However, I was thinking more along the lines of– since Next Hop
Best regards,wrote:
Lotte
Kind regards,
Vicky :-)
On 2 Apr 2016 10:28, "Lotte Steenbrink" <lotte.steenbrink@xxxxxxxxxxxx>
lotte.steenbrink@xxxxxxxxxxxx>:
Hi all,
Am 04.03.2016 um 19:21 schrieb Lotte Steenbrink <
about (and what I remember, so please add stuff that's missing...):
Hi all,
for those who couldn't attend, a quick summary of what we've talked
[manet] which will contain some clarifying questions, comments & also
* Lotte is currently writing up a response to Justin's review send to
figured those were the urgent ones and decided:* Editorial pen has ben passed to Lotte
* we went through Justin's comments that were marked as JWD! since we
does this configuration consist of? Also is the list empty if there is
(AODVv2_INTERFACES isn’t defined before now it should be. Also what
with? This seems like a very LARGE missing piece of required informationCharlie will propose some text
Regarding this one (all other JWD!s are resolved now, yay :) ):
(How does one know which outgoing interface is the neighbor associated
entry Neighbor.Interface to the neighbor table and add an instructionThat's a big one. I think we've decided to add an
message was received
o Neighbor.Interface := Interface on which the RREQ or RREP
Neighbor is used) ?
(plus add checks for Neighbor.Interface being correct everywhere
we've defined that one properly.I'm guessing we'll also have to link this to AODVv2_INTERFACES once
never actually used, and it should be. But I can’t find the right section
I’ve made the following changes so far:
in 4.3. Neighbor Table:
add
Neighbor.Interface
The interface on which the link to the neighbor was established.
in 6.2. Next Hop Monitoring:
change from:
When an RREQ or RREP is received from an IP address
which does not already have an entry in the Neighbor Table, a new
entry is created as described in Section 6.3.
to:
When an RREQ or RREP is received and the Neighbor
Table has no entry where:
o Neighbor.IPAddress == IP address from which the RREQ or RREP was
received
o Neighbor.Interface == Interface on which the RREQ or RREP was
received.
a new entry is created as described in Section 6.3.
in 6.3. Neighbor Table Update:
add
o Neighbor.Interface := Interface on which the RREQ or RREP was
received. MUST equal Interface.Id of one of the entries in the
InterfaceSet (see Section 4.1).
and
If the message is one of the following:
o an RREP which answers a RREQ sent within RREQ_WAIT_TIME over the
same interface as Neighbor.Interface
o an RREP_Ack which answers a RREP sent within RREP_Ack_SENT_TIMEOUT
over the same interface as Neighbor.Interface
…But I’m wondering if that’s enough? LocalRoute.NextHopInterface is
I have an idle route and an unconfirmed route, the unconfirmed route is
Regards,
Lotte
(There wasn’t any text above and it’s not clear how this is enforced.
that actually solves this and said she'd look it up, in case that's notAnother big one, Vicky said she thinks there is some text in the Draft
never actually "travel back" into the routing table, do they? I would've
Ouch again. Unless I oversaw something, the Neighbor Table updates
LocalRoute.NextHop, the following changes must be applied:
When the link to the neighbor is determined to be
bidirectional, the Neighbor Table entry is updated as follows:
[...]
for all routes in the Local Route Set with this neighbor as
[<== Is this a good idea though?!]
o if LocalRoute.State := Unconfirmed, set LocalRoute.State := Idle
o if LocalRoute.State := Invalid, set LocalRoute.State := Idle
LocalRoute.NextHop, LocalRoute.State MUST be set to Invalid
and
When a link to a neighbor is determined to be broken,
o the Neighbor Table entry SHOULD be removed.
o for all routes in the Local Route Set with this neighbor as
*tables* but local route *sets*? aslo, I'm thinking we should define what a
... Would that resolve the issue? (also, why do we have neighbor
RREQ table or list being described which i can check if a RREQ has been
(perhaps I’m missing a table or something but I don’t remember any
no RREP matching our RREP_Ack is found there, no actions are required (asFix: add reference to multicast route message table
(What are we checking! What table or timer is there to check? JWD!)
Fix: add reference to multicast route message table: if
would thus not be in the Multicast table– is this a problem? I'm thinkingBuuut, as I'm typing this, I'm wondering– some RREPs are unicast and
"will".
"and RREP messages may be multicast when the link to
the next router is not known to be bidirectional.
"
in section 4.6, should it? I think we should change the "may" to
to check. There needs to be though. JWD!)
(How is this done? There is no table with recently sent RERR messages
table, so we need to track them separately.Fix: since RERR are always unicast, they're not in the multicast
existence of this table (or not) is not an interop issue.Charlie will write some text for such a RERR table. Note that the
that to "If there are UnreachableAddresses identified in step 2,..."
3. Check if there are unreachable addresses which MUST be reported
in a regenerated RERR
(How do we check? It’s not at all clear how this is done. JWD!)
Fix: a few paragraphs earlier, the draft says:
If any of the above are false, a matching LocalRoute MUST NOT be
made Invalid and the unreachable address MUST NOT be advertised
in a regenerated RERR.
We figured the word "Check" is a bit misleading here, so we'll change
4. For each LocalRoute that needs to be reported:
(it’s not clear how we know which localroutes need to be reported JWD!)
Similar to the issue above: add "as identified in section 7.4.2."
Regards,
Lotte