[adtools] Re: GCC compile error
- From: Gunther Nikl <gni@xxxxxxxx>
- To: adtools@xxxxxxxxxxxxx
- Date: Thu, 28 Jul 2005 17:44:47 +0200
Hello,
> >The attached patch fixes this problem.
>
> Thanks. This solution didn't occur to me :(
It isn't committed yet since I wondered whether I am the only one
seeing this and since I wanted someone to look at the proposed
change. I guess when building with GCC3 the code compiles?
> >Then can anyone explain why "struct rs6000_stack" extend for the baserel
> >stuff? It seems using the existing toc_#? entries would have been
> >possible.
>
> Because (as I said in the other mail) I don't know a lot about the
> internals of the compiler (and didn't have the time to "explore" it),
> so I was proceeding on the assumption that I will change as little as
> possible to existing code and data structures.
Changing as little as possible is very advisable IMHO since it should
make moving forward easier.
If its ok to work on that stuff, I would suggest to use as much existing
stuff as possible to have less changes. In this case I would suggest to
use toc_save_p, toc_size and toc_save_offset. AFAICT, they are unused
but these are probably intented to be used for the PowerOpen-TOC pointer.
Since baserel uses r2 it would be natural to use these toc fields. The
code would still be protected by TARGET_BASEREL.
Gunther
______________________________________________________________________________
Amiga Development tools ML - //www.freelists.org/list/adtools
Homepage...................: http://www.sourceforge.net/projects/adtools
Listserver help............: mailto:adtools-request@xxxxxxxxxxxxx?Subject=HELP
Other related posts:
