[vitunes-commits] [ryanflannery/vitunes] 80fd17: Move handling of _GNU_SOURCE into compat.h

  • From: Ryan Flannery <ryan.flannery@xxxxxxxxx>
  • To: vitunes-commits@xxxxxxxxxxxxx
  • Date: Mon, 16 Jan 2012 15:00:01 -0800

  Branch: refs/heads/master
  Home:   https://github.com/ryanflannery/vitunes
  Commit: 80fd17e8cc3f1c9f78d86c4bc71093505df044ed
      
https://github.com/ryanflannery/vitunes/commit/80fd17e8cc3f1c9f78d86c4bc71093505df044ed
  Author: Ryan Flannery <ryan.flannery@xxxxxxxxx>
  Date:   2012-01-16 (Mon, 16 Jan 2012)

  Changed paths:
    M Makefile.linux
  M commands.h
  M compat.h
  M e_commands.h
  M keybindings.h
  M medialib.h
  M meta_info.h
  M paint.h
  M player.h
  M players/mplayer.h
  M players/player_utils.h
  M playlist.h
  M str2argv.h
  M uinterface.h
  M vitunes.h

  Log Message:
  -----------
  Move handling of _GNU_SOURCE into compat.h

Instead of handling #define'ing _GNU_SOURCE on linux in the Makefile,
move it into compat.h.

First, this is more intuitive and consistent with our handling of
build compatibility issues between bsd's & linux.  Second, this moves
us closer to removing a separate linux Makefile.


  Commit: ebff1bdb46cd797382e53661255c708d7108b343
      
https://github.com/ryanflannery/vitunes/commit/ebff1bdb46cd797382e53661255c708d7108b343
  Author: Ryan Flannery <ryan.flannery@xxxxxxxxx>
  Date:   2012-01-16 (Mon, 16 Jan 2012)

  Changed paths:
    M Makefile
  M Makefile.linux

  Log Message:
  -----------
  Move VPATH spec into common Makefile

With BSD make, one uses ".PATH: dir1 dir2 ..." to specify additional
directories make should look in.  With GNU make, the syntax is
"VPATH = dir1 dir2 ...".

Since BSD make will just interpret "VPATH = ..." as an unused variable
declaration, it should be safe to include there.


  Commit: 28e8d268ad0d80112dbc1be39095cbc78de2a076
      
https://github.com/ryanflannery/vitunes/commit/28e8d268ad0d80112dbc1be39095cbc78de2a076
  Author: Ryan Flannery <ryan.flannery@xxxxxxxxx>
  Date:   2012-01-16 (Mon, 16 Jan 2012)

  Changed paths:
    M Makefile
  R Makefile.linux

  Log Message:
  -----------
  Let 'install' be picked up in $PATH in Makefile

This also removes the need to maintain a Linux-specific Makefile.
Joy.


  Commit: f45d3206db433c370081c8b8afb61c74397880d0
      
https://github.com/ryanflannery/vitunes/commit/f45d3206db433c370081c8b8afb61c74397880d0
  Author: Ryan Flannery <ryan.flannery@xxxxxxxxx>
  Date:   2012-01-16 (Mon, 16 Jan 2012)

  Changed paths:
    M compat.h
  M playlist.h

  Log Message:
  -----------
  Only include ligben.h for OpenBSD builds

This causes a warning about basename(3) on Linux, where basename(3)
should come from string.h (rather than libgen.h) when _GNU_SOURCE is
defined.


  Commit: c8b93238fa9c0a7377e5526d06d3d1b9baaf40d5
      
https://github.com/ryanflannery/vitunes/commit/c8b93238fa9c0a7377e5526d06d3d1b9baaf40d5
  Author: Ryan Flannery <ryan.flannery@xxxxxxxxx>
  Date:   2012-01-16 (Mon, 16 Jan 2012)

  Changed paths:
    M playlist.c

  Log Message:
  -----------
  Vary glob_t count type based on OS

On linux it's a size_t, on OpenBSD it's an int.  Compatability goo,
but it gets the Linux build to 0 warnings and helps with some of the
static analysis tools.


Compare: https://github.com/ryanflannery/vitunes/compare/4c8df8b...c8b9323

Other related posts: