[visionegg] Proposed change to logging interface

Hi again!

I recently noticed that my log files were disappearing every few runs. Distraught, I started investigating. In __init__.py, the default maximum size of the log file is specified at a fixed 100k. I propose that this be configurable :)

This can be done with a few simple changes:

__init__.py, line 91 changed to:
def start_default_logging(maxBytes=100000):

__init__.py, line 104-105 changed to:
log_handler_logfile = logging.handlers.RotatingFileHandler( config.VISIONEGG_LOG_FILE,
maxBytes=maxBytes )

This keeps the behaviour the same by default, but allows it to be changed for those of us who need larger log files. Another option that I've been reading about with the RotatingFileHandler is the ability to actually rotate files. I don't know how useful that would be to VisionEggers, but it could be easily implemented in the same way.

Another thing... Would it make life easier for the maintainers (I'm assuming that's just Andrew Straw) if I were to actually get CVS going and submit diffs instead of these little blurbs? I have to get it going at some point this summer anyways.

Tony
======================================
The Vision Egg mailing list
Archives: http://www.freelists.org/archives/visionegg
Website: http://www.visionegg.org/mailinglist.html

Other related posts: