On 26/03/17 17:49, Francesco Lattanzio wrote:
On Sun, Mar 26, 2017 at 03:56:18PM +0000, Antti Kantee wrote:
On 26/03/17 09:11, Francesco Lattanzio wrote:
Yes and no. Yes in that it's a bug, but no in that configure.ac is also
wrong. exporting CC in buildrump.sh in the snippet that runs configure
should fix it, at least assuming you're running buildrump.sh with
"CC=clang ./buildrump.sh". Want to try it (and submit a pull req if so)?
Done. See below.
I don't see a pull req in buildrump.sh?
Sorry, I got confused and answered with the wrong answer.
The correct answer is: I couldn't reproduce this issue (that is, gcc
used to check for pthread_setname_np() and Clang to compile
librumpuser). I think I mixed the config.log and the buildrump.sh output
from different runs.
But speaking of your patch to librumpuser, please just add the necessary
things for FreeBSD using the existing conventions. For example, you
cannot add a requirement for -lpthread, since some systems have the same
functionality in libc without supplying a libpthread at all, and they
would now be broken.
You're right -- I was mislead by the LIBS="${LIBS} -lpthread" line to
think libpthread to be a required library. I'll fix it.
Thinking about it, that might be the reason the
configure script uses AC_TRY_COMPILE instead of LINK to check for
pthread stuff -- can't remember for sure anymore.
Using AC_TRY_COMPILE implies that the LIBS="${LIBS} -lpthread" is
superfluos. Ain't it?
