[procps] Re: [pull] two weeks of fixes
- From: Jim Warner <james.warner@xxxxxxxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Mon, 6 Feb 2012 09:23:31 -0600
On Feb 5, 2012, at 4:29 PM, Sami Kerola wrote:
> usage [smatch scan]
> vmstat: open file should be closed, not freed
> top: initialize rbuf variable [cppscan]
> libprocps: open file should be closed, not freed
Hi Sami,
Could you please discard that top change.
It makes no sense to trade a simple store instruction for the memset function
call overhead.
Thanks,
Jim
p.s. I know you really like smatch, but he's not always right...
Other related posts:
