[procps] Re: [PATCH] 'vmstat -S M 1' and 'vmstat -S m 1' output of the 'si and 'so' fields is always zero
- From: Jaromir Capik <jcapik@xxxxxxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Wed, 1 Aug 2012 09:53:04 -0400 (EDT)
Just one more thing, Mike.
Our patches differ a bit. Look at the brackets.
Your patch is not correct.
You distort the sleep_half rounding mechanism by
unitConvert function whilst it must stay unit
independent in order to work correctly.
sleep_half/sleep_time gives exactly 1/2 and
thus works like fixed point rounding.
If you convert sleep_half with unitconvert, then
you distort this 1/2 so that the result is
truncation of the value instead of rounding.
It's because it adds only a thousand times lower
value. You also missed the unitConvert type.
It's still "int" after applying your patch,
but the function now needs to accept "long".
Please, do not take that personally, but I'm
quite proud of my moral values and I would
NEVER steal anybody's work. In fact I always
fight for keeping the contributors and their
email address in spec file headers when
somebody wants to remove them.
Even if I don't expect you to believe that,
please, at least try to do that.
Thank you.
Regards,
Jaromir.
> > Hello,
> >
>
> Hello Mike.
>
> > Jaromir wrote:
> > > One of our engineers discovered a bug in the vmstat unit
> > > conversions.
> >
> > That should have read:
> > > A random person on the Internet discovered a bug in the vmstat
> > > unit
> > > conversions.
>
> Sorry Mike. This is just a coincidence.
> In fact it was Paul Needle from Red Hat, who reported the issue on
> 11-JUL.
> You did exactly the same on 17-JUL, but I read your bug report few
> days
> after releasing the patch.
>
> >
> > Jaromir also wrote:
> > > I analysed the code and found the following ...
> >
> > That should have read:
> > > This random person analysed the code and found the following...
>
> Even if the changes made are almost identical, the patch was really
> created by me from scratch. There is simply no other easy solution
> for the problem.
>
> >
> > Jaromir finished by saying:
> > > The patch is attached ...
> >
> > That should have read:
> > > His patch is attached ...
>
> Again. It's really my patch.
>
> >
> > I am that random person. Taking credit for other people's work is
> > not cool.
>
> If you want credits, then take them. I have different
> priorities in life, than being visible.
>
> Regards,
> Jaromir.
>
>
> >
> > References:
> > [1] https://bugzilla.redhat.com/show_bug.cgi?id=840747
> > [2]
> > //www.freelists.org/post/procps/PATCH-vmstat-S-M-1-and-vmstat-S-m-1-output-of-the-si-and-so-fields-is-always-zero
> >
> >
>
>
Other related posts:
