[procps] Re: [PATCH v2] sysctl: restore old -p handling

On Fri, May 4, 2012 at 9:25 PM, Mike Frysinger <vapier@xxxxxxxxxx> wrote:
> On Friday 04 May 2012 15:07:36 Sami Kerola wrote:
>> IMHO avoiding optional options still makes sense. Syntax of the
>> optional arguments is exactly different than the required argument,
>> which obviously is cause of confusion and therefore intolerable.
>
> sure, i'm fine with that.  just taking offense at the commit log :).

Fixed, thought it does not matter because of...

> i would highlight that this will break the new behavior introduced with 3.3.2:
>        sysctl -p/some/file
> i.e. we're going back to the previous syntax -- always requiring a space:
>        sysctl -p /some/file
>
> this release hasn't been out there for too long, so maybe no one will notice,
> so it's ok.

...you are right. The latest commit is mistake. Both -p/path/to/file
and -p /path/to/file need to be supported. Which puts the following
patch to reject queue.

https://gitorious.org/~kerolasa/procps/sami-procps-ng/commit/df68e1d653f431e53f70a1ad38955291f363f157

Other related posts: