[pisa-src] Re: the future of (internal) libconfig
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Wed, 26 Aug 2009 14:33:48 +0200
On Wed, Aug 26, 2009 at 02:07:27PM +0200, Thomas Jansen wrote:
> On Wed, Aug 26, 2009 at 01:40:37PM +0200, Diego Biurrun wrote:
>
> > Here is the patch that removes libconfig without the 'svn rm' of the
> > libpisa directory. I'd appreciate a second pair of eyes on the auto*
> > stuff.
>
> Most of it looks fine. I still have to actually test it though.
I compiled it locally, on morpheus and I had Dominik and Jahn test it.
This part I am confident about.
> > --- pairing/Makefile.am (revision 869)
> > +++ pairing/Makefile.am (working copy)
> > @@ -32,7 +32,6 @@
> > LDADD += -lpisa -lconfig
> > - LDFLAGS += -L$(top_srcdir)/libpisa
> > -L$(top_srcdir)/libpisa/libconfig-1.3.2
>
> You remove the entire line, is the "LDFLAGS += -L$(top_srcdir)/libpisa"
> part obsolete as well?
No, that was an oversight on my part, thanks for spotting.
> > --- configure.ac (revision 869)
> > +++ configure.ac (working copy)
> > @@ -35,7 +35,6 @@
> > AC_CHECK_LIB([crypto], DSA_generate_key,, AC_MSG_ERROR(openssl lib not
> > found))
> > -AC_CHECK_LIB([config], [config_setting_index],
> > ac_cv_included_libconfig=no, ac_cv_included_libconfig=yes)
>
> I'd rather modify that line to get an error message if the lib can't be found.
> The line above could be used for reference, e.g.
> -AC_CHECK_LIB([config], [config_setting_index], ac_cv_included_libconfig=no,
> ac_cv_included_libconfig=yes)
> +AC_CHECK_LIB([config], [config_setting_index],, AC_MSG_ERROR(libconfig not
> found))
Yes, that's much better!
Thanks for the good review. I'll commit this in a moment.
Diego
Other related posts:
